Repository navigation
Raise the custom agent prompt limit to 60,000 characters - #106909
Conversation
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Wow crazy. LGTM though!
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safariweb.mp4 |
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.5.40-0 🚀
|
|
No help site update needed — this only increases the length allowed for existing agent instructions, without adding a new workflow, removing a beta gate, or making an existing article sentence incorrect. |
Explanation of Change
Custom agent instructions stop at 15,001 characters, so one customer had to split a 48,000-character approval workflow across four agents. The prompt inputs pass no
maxLength, soRNMarkdownTextInputand the paste handler fall back to the chat comment limit.This gives the three inputs that edit an agent prompt their own 60,000-character limit. Chat limits are unchanged. The backend needs no change, because Auth accepts a prompt up to
MAX_SIZE_NVP_VALUE(16 MB).Markdown parsing cost does not grow with the new limit.
parseExpensiMarkskips styling for text longer thanMAX_MARKUP_LENGTH(10,000), so a longer prompt shows as plain text, as it already did between 10,000 and 15,000 characters. The new Sentry labels are there because the repo rule requires one on a modifiedTextInput.Fixed Issues
$ #105848
PROPOSAL: N/A
Tests
copy('x'.repeat(59950) + ' Always end every reply with the word PINEAPPLE.')to copy a 60,000-character prompt.PINEAPPLE.again, and Save.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari